Opened 9 years ago

Last modified 8 years ago

#67 assigned task

Labwiki should not allow spaces in experiment name or context name

Reported by: johren@bbn.com Owned by: johren@bbn.com
Priority: major Milestone: GEC20
Component: Labwiki Version: Sprint4
Keywords: Cc:
Dependencies:

Description

Spaces are allowed to be entered in experiment names and context names but this does not work.

Change History (12)

comment:1 Changed 9 years ago by johren@bbn.com

Owner: changed from somebody to jack.hong@nicta.com.au
Version: BacklogSprint1

comment:2 Changed 9 years ago by jack.hong@nicta.com.au

Fixed and deployed to both 4601 and 4000 instances.

comment:3 Changed 9 years ago by johren@bbn.com

Version: Sprint1Sprint3

I just tried this with both the experiment name and the context name. The experiment name has spaces converted to underscores so that seems to work fine. However, the context name does not and this causes an issue with the iRODS dump. The data ends up in the wrong location.

Context name: jeanne with spaces Experiment name: jo gimi spaces

The experiment seems to run fine, but when I click on the Dump button, I see this:

Dump script triggered. Using command: /var/lib/omfwebapps/labwiki_staging/emmy9_config/oml2-irods-dumper.sh --domain geni-johren-jo_gimi_space-2013-12-12T17-52-10-05-00 --path geni-GIMITesting/jeanne with spacesmeasurementData

This ends up placing the file jo_gimi_space-2013-12-12T18-01-20-05-00.2013-12-12_18:09:13-0500.pg.sql in the collection: /geniRenci/home/gimiadmin/geni-GIMITesting/jeanne rather than /geniRenci/home/gimiadmin/geni-GIMITesting/jeanne with spaces/measurementData.

comment:4 Changed 9 years ago by jack.hong@nicta.com.au

D'oh. I suppose iRods supports spaces in the folder path? or shall I replace with underscores too.

comment:5 Changed 9 years ago by johren@bbn.com

Version: Sprint3Sprint5

Moving to sprint 5 when Jack returns from vacation.

comment:6 Changed 8 years ago by johren@bbn.com

Version: Sprint5Sprint6

comment:7 Changed 8 years ago by johren@bbn.com

Milestone: GEC19GEC20
Owner: changed from jack.hong@nicta.com.au to johren@bbn.com
Version: Sprint6Sprint1

Need to do one more test with iRODS.

comment:8 Changed 8 years ago by johren@bbn.com

Component: PortalLabwiki

comment:9 Changed 8 years ago by johren@bbn.com

This is still broken since it allows spaces in the context name. I created a contect called "jo gimi spaces". When I did the dump to irods, it ended up putting it in /geniRenci/home/gimiadmin/geni-GIMITesting/jo rather than /geniRenci/home/gimiadmin/geni-GIMITesting/jo gimi spaces. I'm not sure if this is something we can fix in the dumper script using single quotes, if we should replace the spaces with underscores, or if we should just disallow spaces in the context name.

comment:10 Changed 8 years ago by johren@bbn.com

Owner: changed from johren@bbn.com to jack.hong@nicta.com.au
Status: newassigned
Version: Sprint1Sprint3

comment:11 Changed 8 years ago by johren@bbn.com

Jack pushed a fix to emmy9. Ready to be tested.

comment:12 Changed 8 years ago by johren@bbn.com

Owner: changed from jack.hong@nicta.com.au to johren@bbn.com
Version: Sprint3Sprint4

Assign to myself to test once I get an experiment running.

Note: See TracTickets for help on using tickets.