site metadata submission leads to duplicate address submission

[chaos@bbn.com]

The address table on gmoc-db2 contains:

  (2063,'10 Moulton St.',NULL,'Cambridge',NULL,'02138','US',NULL,NULL,0),
  (2064,'10 Moulton St.',NULL,'Cambridge',NULL,'02138','US',NULL,NULL,0),
  (2065,'10 Moulton St.',NULL,'Cambridge',NULL,'02138','US',NULL,NULL,0),
  (2066,'10 Moulton St.',NULL,'Cambridge',NULL,'02138','US',NULL,NULL,0),
  (2067,'10 Moulton St.',NULL,'Cambridge',NULL,'02138','US',NULL,NULL,0),
  (2068,'10 Moulton St.',NULL,'Cambridge',NULL,'02138','US',NULL,NULL,0);

It appears that every time this XML data is submitted:

<?xml version="1.0" ?>
<gmoc_topology time="1349129423" version="4">
        <location name="urn:publicid:IDN+gmoc.geni.net+location+10_Moulton_St">
                <address city="Cambridge" country="US" postal_code="02138" state="MA" street1="10 Moulton St."/>
        </location>
        <contact email="gpo-infra@geni.net" given_name="GPO" last_name="Infrastructure Group" urn="urn:publicid:IDN+gmoc.geni.net+contact+gpo-infra_geni.net"/>
        <organization location="urn:publicid:IDN+gmoc.geni.net+location+10_Moulton_St" name="urn:publicid:IDN+gmoc.geni.net+organization+BBN" primary_contact="urn:publicid:IDN+gmoc.geni.net+contact+gpo-infra_geni.net" type="campus"/>
        <pop location="urn:publicid:IDN+gmoc.geni.net+location+10_Moulton_St" name="urn:publicid:IDN+gmoc.geni.net+pop+gpolab" operator="urn:publicid:IDN+gmoc.geni.net+organization+BBN"/>
</gmoc_topology>

a new address line for 10 Moulton St. is added. This seems messy at best, and might cause trouble if anything wants to search on address data.

[chaos@bbn.com]

Kevin made a change to address this, and now i'm seeing:

tau-verde,[~],13:10(0)$ sudo -u ganglia /usr/bin/report_site_metadata -d
[sudo] chaos's password on tau-verde:
<?xml version="1.0" ?>
<gmoc_topology time="1349132179" version="4">
        <location name="urn:publicid:IDN+gmoc.geni.net+location+10_Moulton_St">
                <address city="Cambridge" country="US" postal_code="02138" state="MA" street1="10 Moulton St."/>
        </location>
        <contact email="gpo-infra@geni.net" given_name="GPO" last_name="Infrastructure Group" urn="urn:publicid:IDN+gmoc.geni.net+contact+gpo-infra_geni.net"/>
        <organization location="urn:publicid:IDN+gmoc.geni.net+location+10_Moulton_St" name="urn:publicid:IDN+gmoc.geni.net+organization+BBN" primary_contact="urn:publicid:IDN+gmoc.geni.net+contact+gpo-infra_geni.net" type="campus"/>
        <pop location="urn:publicid:IDN+gmoc.geni.net+location+10_Moulton_St" name="urn:publicid:IDN+gmoc.geni.net+pop+gpolab" operator="urn:publicid:IDN+gmoc.geni.net+organization+BBN"/>
</gmoc_topology>

Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 223.
Global symbol "$location" requires explicit package name at xchange2db3 line 227.
Execution of xchange2db3 aborted due to compilation errors.


Result: 16

[chaos@bbn.com]

This is fixed. Before and after submission, the address table ends with:

  (2075,'10 Moulton St.',NULL,'Cambridge','MA','02138','US',NULL,NULL,0);