Opened 11 years ago

Closed 11 years ago

#168 closed (fixed)

GMOCClient.store() should provide more information about non-200 HTTP responses

Reported by: chaos@bbn.com Owned by: somebody
Priority: minor Milestone:
Component: Clients Version:
Keywords: v1.2.16 Cc:
Dependencies:

Description

When GMOCClient.store() receives a non-200 (OK) response to relational XML submission, it does not reflect the HTTP response code in its status, instead always reporting GMOC_ERROR_BAD_SCHEMA (16). This is confusing. Make the return code vary depending on what HTTP response code was received.

Change History (2)

comment:1 Changed 11 years ago by chaos@bbn.com

Milestone: GPO GEC17 priorities
Priority: major → minor

I'm actually going to delist this as priority. It'd be good to unconfuse it, but the HTTP result code is also stored in the GMOCClient object --- it's just not what store() returns. I've successfully modified my client code to report both the HTTP response code and the error message in addition to the return code, and this does work.

So disambiguating the return value of store() is more of a "nice to have" from my point of view right now.

comment:2 Changed 11 years ago by chaos@bbn.com

Resolution: → fixed
Status: new → closed

This is fixed in gmoc.py-1.2.17 --- on authorization failure, the store() function returns gmoc.GMOC_ERROR_UNAUTHORIZED.

Note: See TracTickets for help on using tickets.