Parameters set in the __init__ method should be validated

[sedwards@bbn.com]

The __init__() method for each object should call the setter functions and validdate the value before it gets set.

See for example, Organization's escalationContact.

[sedwards@bbn.com]

Started looking at this. PhysicalAddress?' fields aren't being checked.

Kevin says this will get checked as part of the reference objects by id discussion.

[sedwards@bbn.com]

Kevin said that this is part of the ref-by-id fix. And it's currently possible to generate a PhysicalAddress object which can't be serialized to XML. So that's not good.

Bumping up to the list for the next release. If we can't do it we can bump it back down.

[sedwards@bbn.com]

PhysicalAddress now works. I checked the various non-Object parameters to make sure they were being validated and they are fine.

Perhaps I should check the Object parameters as well....

[sedwards@bbn.com]

Ok. I've found one small issue.

If I do:

        self.myResMap = ResourceMapping("myMapping",
                                        type="foo",
                                        sliver=self.mySliver,
                                        resource=self.myOrg)

(Notice self.myOrg is not a Resource.)

I get:

Traceback (most recent call last):
  File "gmoc_unittest.py", line 224, in setUp
    resource=self.myOrg)#, #self.myResource)
  File "/home/sedwards/monitoring2/monitoring/gmoc_client/gmoc.py", line 1247, in __init__
    self.sliver = sliver
  File "/home/sedwards/monitoring2/monitoring/gmoc_client/gmoc.py", line 1284, in sliver
    slivers = self._resource._slivers
AttributeError: 'Organization' object has no attribute '_slivers'

I think there is no validator on ResourceMapping's resource parameter.

[sedwards@bbn.com]

Also I was able to set:

        self.myResource.interfaces.append( self.myResource )

I think the validator for the list of interfaces on a Resource object isn't working.

[sedwards@bbn.com]

I was also able to set:

       self.mySA.users = [self.myOrg]

[sedwards@bbn.com]

We've decided that fixing this is likely to introduce more problems than it fixes. Removing the label for the current release.

[chaos@bbn.com]

This is too generic (and we did a lot of work on this topic in January). I'm going to close it as fixed, and open tickets for individual instances of gmoc.py not validating __init__ parameters as we discover them.