Opened 12 years ago

Closed 12 years ago

#108 closed (fixed)

aggregate_instantiation version fields are not long enough for git tags

Reported by: chaos@bbn.com Owned by: somebody
Priority: major Milestone: gmoc.py data submission debugging
Component: Database Version:
Keywords: Cc:
Dependencies:

Description

The slice_authority_instantiation table defines:

CREATE TABLE `slice_authority_instantiation` (
...
  `version` varchar(20) NOT NULL,
...

However, ProtoGENI uses a git hash as a version string, e.g.:

<sa                                                                               name="urn:publicid:IDN+pgeni1.gpolab.bbn.com+authority+sa"                      organization="urn:publicid:IDN+gmoc.geni.net+organization+BBN"                  pop="urn:publicid:IDN+gmoc.geni.net+pop+gpolab"                                 type="protogeni"                                                                urn="urn:publicid:IDN+pgeni1.gpolab.bbn.com+authority+sa"                       version="16c3451f2d049fa0f679f77d218f23e282d9026a"
>

Since the 40-character git tag is used as a version string by a major AM/SA type, it should be legal for a version string to be that long, and the database should store the entire string.

This should be fixed for both slice authorities and aggregates.

Change History (3)

comment:1 Changed 12 years ago by chaos@bbn.com

Okay, there are now some SA entries like:

  (10,487860,487856,'protogeni','16c3451f2d049fa0f679f77d218f23e282d9026a',1792,40)

so this is fixed for slice authorities. However, we still have:

CREATE TABLE `aggregate_instantiation` (
...
  `version` varchar(20) NOT NULL,

This needs to be fixed for aggregate_instantiation too.

comment:2 Changed 12 years ago by sedwards@bbn.com

Summary: aggregate_instantiation and slice_authority_instantiation version fields are not long enough for git tagsaggregate_instantiation version fields are not long enough for git tags

Updated title of ticket to indicate the one that was fixed and the remaining item.

comment:3 Changed 12 years ago by chaos@bbn.com

Resolution: fixed
Status: newclosed

This is fixed in the DB for aggregate too now:

CREATE TABLE `aggregate_instantiation` (
...
  `version` varchar(64) NOT NULL,
Note: See TracTickets for help on using tickets.