Opened 6 years ago

Closed 6 years ago

#1096 closed (fixed)

Stiching slice credentials file name prevents multiple concurrent operations

Reported by: lnevers@bbn.com Owned by: Aaron Helsinger
Priority: major Milestone:
Component: STITCHING Version: SPIRAL5
Keywords: Network Stitching Cc:
Dependencies:

Description

The stitcher tool currently creates a file named /tmp/saved-stitching-slice-cred.xml while executing sliver commands. This naming causes problems when multiple stitched slivers commands are being executed by one user. Here is an example.

While deleting a stitching sliver (lndemo) and creating a second sliver (eg-gpo-ig-utah) in a second window. I noticed that the delete operation started failing because the content of the /tmp/saved-stitching-slice-cred.xml were for the second slice:

11:15:27 WARNING  stitcher: Failed to delete reservation at https://www.emulab.net:12369/protogeni/xmlrpc/am: 
Cannot do DeleteSliver for urn:publicid:IDN+ch.geni.net:ln-prj+slice+lndemo:
Could not get slice credential: Read slice cred from /tmp/saved-stitching-slice-cred.xml - BUT it is for 
slice urn:publicid:IDN+ch.geni.net:ln-prj+slice+eg-gpo-ig-utah, not expected 
urn:publicid:IDN+ch.geni.net:ln-prj+slice+lndemo!

Also, if two different users run stitcher commands on the same systems there are permissions problem in overwriting the file.

A more unique file naming convention is needed, which should include both the user and the slice name in the file naming.

Change History (5)

comment:1 Changed 6 years ago by Aaron Helsinger

Status: newassigned

comment:2 Changed 6 years ago by Aaron Helsinger

Luisa:

Should the saved slice credential be deleted when stitcher exits?

If I do this, then you can't use the same saved credential for your later deletesliver call.

If I do not do this, then your /tmp directory will have all these saved slice credential files hanging around.

What do you prefer?

comment:3 Changed 6 years ago by Josh Smift

A random thought from the peanut gallery: Do those credentials expire? If so, could stitcher check the expiration dates, and delete the expired ones?

comment:4 Changed 6 years ago by lnevers@bbn.com

I would rather the file get cleaned up and that stitcher run a getslicecred operation before executing the delete.

We already have a lot of files left on the file system, we may want to delete them whenever possible and of course, when it does not impact a feature.

comment:5 Changed 6 years ago by Aaron Helsinger

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.